vfs: fix RealFSProvider watchFile listener#64537
Open
Y1D7NG wants to merge 1 commit into
Open
Conversation
Fixes: nodejs#64536 Signed-off-by: y1d7ng <y1d7ng@yeah.net>
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64537 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 739 739
Lines 241669 241668 -1
Branches 45543 45546 +3
=======================================
+ Hits 218087 218099 +12
+ Misses 15150 15108 -42
- Partials 8432 8461 +29
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64536
RealFSProvider.watchFileignored the listener, so changes never reached code.